feat: update to latest did spec #92

mirceanis · 2021-03-11T20:34:07Z

fixes #91
implements w3c-ccg/did-method-web#7

BREAKING CHANGES:

resolver is now returning a DIDResolutionResult that wraps a DIDDocument
No errors are thrown, instead returned as didResolutionMetadata.error/message

fixes #91 implements w3c-ccg/did-method-web#7 BREAKING CHANGES: * resolver is now returning a DIDResolutionResult that wraps a DIDDocument * No errors are thrown, instead returned as didResolutionMetadata.error/message

rado0x54 · 2021-03-11T21:26:23Z

Code coverage dropped, which seems a blocking criteria.

src/resolver.ts

rado0x54

CodeCov, Introduction of URL Encoding and loop comments should be addressed before merging.

codecov · 2021-03-12T10:31:50Z

Codecov Report

Merging #92 (752f118) into master (926eb1f) will increase coverage by 4.54%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master       #92      +/-   ##
===========================================
+ Coverage   95.45%   100.00%   +4.54%     
===========================================
  Files           1         1              
  Lines          22        29       +7     
  Branches        6         9       +3     
===========================================
+ Hits           21        29       +8     
+ Misses          1         0       -1

Impacted Files	Coverage Δ
src/resolver.ts	`100.00% <100.00%> (+4.54%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2ab90...752f118. Read the comment docs.

src/resolver.ts

# [2.0.0](1.3.5...2.0.0) (2021-03-15) ### Features * update to latest did spec ([#92](#92)) ([4779436](4779436)), closes [#91](#91) ### BREAKING CHANGES * Resolver now returns a `DIDResolutionResult` that wraps a DIDDocument. No errors are thrown, instead returned as `didResolutionMetadata.error/message`

uport-automation-bot · 2021-03-15T17:54:11Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@context

# 1.0.0 (2023-04-26) ### Bug Fixes * **build:** publish types in package.json ([174afe8](174afe8)) * CORS bug ([decentralized-identity#88](https://github.com/veramolabs/plc-did-resolver/issues/88)) ([2a5b5d1](2a5b5d1)) * **deps:** bump did-resolver to 3.1.0 ([08358ec](08358ec)) * **deps:** bump did-resolver to 3.1.3 ([f62af45](f62af45)) * **deps:** groom the build scripts and dependencies ([decentralized-identity#120](https://github.com/veramolabs/plc-did-resolver/issues/120)) ([757f6ec](757f6ec)) * **deps:** pin dependencies ([decentralized-identity#89](https://github.com/veramolabs/plc-did-resolver/issues/89)) ([926eb1f](926eb1f)) * **deps:** update all non-major dependencies ([decentralized-identity#93](https://github.com/veramolabs/plc-did-resolver/issues/93)) ([13d8f18](13d8f18)) * **deps:** update all non-major dependencies to v17.0.2 ([0e9e2f0](0e9e2f0)) * **deps:** update all non-major dependencies to v18.1.0 ([cd3ed19](cd3ed19)) * **deps:** update all non-major dependencies to v18.2.0 ([cd99aa3](cd99aa3)) * **deps:** update dependencies, remove ts-jest ([789ec69](789ec69)) * **deps:** update dependency did-resolver to v1.1.0 ([decentralized-identity#39](https://github.com/veramolabs/plc-did-resolver/issues/39)) ([4ade39d](4ade39d)) * **deps:** update dependency did-resolver to v2 ([decentralized-identity#56](https://github.com/veramolabs/plc-did-resolver/issues/56)) ([b420866](b420866)) * **deps:** update dependency did-resolver to v2.1.1 ([decentralized-identity#70](https://github.com/veramolabs/plc-did-resolver/issues/70)) ([0a0f902](0a0f902)) * **deps:** update dependency did-resolver to v3 ([decentralized-identity#94](https://github.com/veramolabs/plc-did-resolver/issues/94)) ([18d1a1d](18d1a1d)) * **deps:** Update dependency did-resolver to v3.1.1 ([91cc1c6](91cc1c6)) * **deps:** Update dependency did-resolver to v3.1.2 ([7902b3f](7902b3f)) * **deps:** Update dependency did-resolver to v3.1.3 ([d77839f](d77839f)) * **deps:** Update dependency did-resolver to v3.1.4 ([02d4c7d](02d4c7d)) * **deps:** Update dependency did-resolver to v3.1.5 ([0728ffb](0728ffb)) * **deps:** Update dependency did-resolver to v3.2.0 ([d33f51e](d33f51e)) * **deps:** Update dependency did-resolver to v3.2.2 ([f494fbe](f494fbe)) * **deps:** Update dependency did-resolver to v4 ([74b825f](74b825f)) * **deps:** Update dependency did-resolver to v4.0.1 ([63d7fc2](63d7fc2)) * **deps:** Update dependency did-resolver to v4.1.0 ([81fa649](81fa649)) * **deps:** update dependency react-scripts to v5 ([bbc4b35](bbc4b35)) * **deps:** update dependency react-scripts to v5.0.1 ([36d0e22](36d0e22)) * **deps:** update react monorepo to v18 ([8f21c88](8f21c88)) * remove checks for a [@context](https://github.com/context) field ([b814b6c](b814b6c)), closes [decentralized-identity#26](https://github.com/veramolabs/plc-did-resolver/issues/26) ### Features * forked web-did-resolver and refactored to be plc-did-resolver ([7fdeefe](7fdeefe)) * remove default export ([3952bef](3952bef)) * remove default export ([9ef0b37](9ef0b37)) * support for path in the did ([904d88c](904d88c)), closes [decentralized-identity#32](https://github.com/veramolabs/plc-did-resolver/issues/32) [decentralized-identity#33](https://github.com/veramolabs/plc-did-resolver/issues/33) * update to latest did spec ([decentralized-identity#92](https://github.com/veramolabs/plc-did-resolver/issues/92)) ([4779436](4779436)), closes [decentralized-identity#91](https://github.com/veramolabs/plc-did-resolver/issues/91) * use cross-fetch instead of XMLHttpRequest ([decentralized-identity#15](https://github.com/veramolabs/plc-did-resolver/issues/15)) ([dadf682](dadf682)) * use cross-fetch instead of XMLHttpRequest ([decentralized-identity#15](https://github.com/veramolabs/plc-did-resolver/issues/15)) ([4378c71](4378c71)) ### BREAKING CHANGES * Resolver now returns a `DIDResolutionResult` that wraps a DIDDocument. No errors are thrown, instead returned as `didResolutionMetadata.error/message`

@context

# 1.0.0 (2024-01-22) ### Bug Fixes * CORS bug ([decentralized-identity#88](https://github.com/veramolabs/peer-did-resolver/issues/88)) ([2a5b5d1](2a5b5d1)) * **deps:** bump @aviarytech/did-peer to 0.0.22 ([#3](#3)) ([3605a4a](3605a4a)) * **deps:** bump did-resolver to 3.1.0 ([08358ec](08358ec)) * **deps:** bump did-resolver to 3.1.3 ([f62af45](f62af45)) * **deps:** groom the build scripts and dependencies ([decentralized-identity#120](https://github.com/veramolabs/peer-did-resolver/issues/120)) ([757f6ec](757f6ec)) * **deps:** pin dependencies ([decentralized-identity#89](https://github.com/veramolabs/peer-did-resolver/issues/89)) ([926eb1f](926eb1f)) * **deps:** update all non-major dependencies ([decentralized-identity#93](https://github.com/veramolabs/peer-did-resolver/issues/93)) ([13d8f18](13d8f18)) * **deps:** update all non-major dependencies to v17.0.2 ([0e9e2f0](0e9e2f0)) * **deps:** update all non-major dependencies to v18.1.0 ([cd3ed19](cd3ed19)) * **deps:** update all non-major dependencies to v18.2.0 ([cd99aa3](cd99aa3)) * **deps:** update dependencies, remove ts-jest ([789ec69](789ec69)) * **deps:** update dependency did-resolver to v1.1.0 ([decentralized-identity#39](https://github.com/veramolabs/peer-did-resolver/issues/39)) ([4ade39d](4ade39d)) * **deps:** update dependency did-resolver to v2 ([decentralized-identity#56](https://github.com/veramolabs/peer-did-resolver/issues/56)) ([b420866](b420866)) * **deps:** update dependency did-resolver to v2.1.1 ([decentralized-identity#70](https://github.com/veramolabs/peer-did-resolver/issues/70)) ([0a0f902](0a0f902)) * **deps:** update dependency did-resolver to v3 ([decentralized-identity#94](https://github.com/veramolabs/peer-did-resolver/issues/94)) ([18d1a1d](18d1a1d)) * **deps:** Update dependency did-resolver to v3.1.1 ([91cc1c6](91cc1c6)) * **deps:** Update dependency did-resolver to v3.1.2 ([7902b3f](7902b3f)) * **deps:** Update dependency did-resolver to v3.1.3 ([d77839f](d77839f)) * **deps:** Update dependency did-resolver to v3.1.4 ([02d4c7d](02d4c7d)) * **deps:** Update dependency did-resolver to v3.1.5 ([0728ffb](0728ffb)) * **deps:** Update dependency did-resolver to v3.2.0 ([d33f51e](d33f51e)) * **deps:** Update dependency did-resolver to v3.2.2 ([f494fbe](f494fbe)) * **deps:** Update dependency did-resolver to v4 ([74b825f](74b825f)) * **deps:** Update dependency did-resolver to v4.0.1 ([63d7fc2](63d7fc2)) * **deps:** update dependency react-scripts to v5 ([bbc4b35](bbc4b35)) * **deps:** update dependency react-scripts to v5.0.1 ([36d0e22](36d0e22)) * **deps:** update react monorepo to v18 ([8f21c88](8f21c88)) * remove checks for a [@context](https://github.com/context) field ([b814b6c](b814b6c)), closes [decentralized-identity#26](https://github.com/veramolabs/peer-did-resolver/issues/26) ### Features * refactor to resolve peer-did ([e04640c](e04640c)) * remove default export ([3952bef](3952bef)) * remove default export ([9ef0b37](9ef0b37)) * support for path in the did ([904d88c](904d88c)), closes [decentralized-identity#32](https://github.com/veramolabs/peer-did-resolver/issues/32) [decentralized-identity#33](https://github.com/veramolabs/peer-did-resolver/issues/33) * update to latest did spec ([decentralized-identity#92](https://github.com/veramolabs/peer-did-resolver/issues/92)) ([4779436](4779436)), closes [decentralized-identity#91](https://github.com/veramolabs/peer-did-resolver/issues/91) * use cross-fetch instead of XMLHttpRequest ([decentralized-identity#15](https://github.com/veramolabs/peer-did-resolver/issues/15)) ([dadf682](dadf682)) * use cross-fetch instead of XMLHttpRequest ([decentralized-identity#15](https://github.com/veramolabs/peer-did-resolver/issues/15)) ([4378c71](4378c71)) ### BREAKING CHANGES * Resolver now returns a `DIDResolutionResult` that wraps a DIDDocument. No errors are thrown, instead returned as `didResolutionMetadata.error/message`

feat: update to latest did spec

1331cc0

fixes #91 implements w3c-ccg/did-method-web#7 BREAKING CHANGES: * resolver is now returning a DIDResolutionResult that wraps a DIDDocument * No errors are thrown, instead returned as didResolutionMetadata.error/message

mirceanis requested review from awoie and rado0x54 March 11, 2021 20:34

rado0x54 reviewed Mar 11, 2021

View reviewed changes

src/resolver.ts Show resolved Hide resolved

rado0x54 reviewed Mar 11, 2021

View reviewed changes

src/resolver.ts Show resolved Hide resolved

rado0x54 reviewed Mar 11, 2021

View reviewed changes

src/resolver.ts Show resolved Hide resolved

rado0x54 suggested changes Mar 11, 2021

View reviewed changes

test: add tests for more corner cases

485edbf

mirceanis requested a review from rado0x54 March 12, 2021 10:32

rado0x54 reviewed Mar 15, 2021

View reviewed changes

src/resolver.ts Outdated Show resolved Hide resolved

style: comment out redundant break statement

752f118

mirceanis requested a review from rado0x54 March 15, 2021 16:36

mirceanis merged commit 4779436 into master Mar 15, 2021

mirceanis deleted the feat/update-to-spec branch March 15, 2021 17:52

uport-automation-bot added the triage This issue is currently being examined label Mar 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update to latest did spec #92

feat: update to latest did spec #92

mirceanis commented Mar 11, 2021 •

edited

Loading

rado0x54 commented Mar 11, 2021

rado0x54 left a comment

codecov bot commented Mar 12, 2021 •

edited

Loading

uport-automation-bot commented Mar 15, 2021

feat: update to latest did spec #92

feat: update to latest did spec #92

Conversation

mirceanis commented Mar 11, 2021 • edited Loading

rado0x54 commented Mar 11, 2021

rado0x54 left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 12, 2021 • edited Loading

Codecov Report

uport-automation-bot commented Mar 15, 2021

mirceanis commented Mar 11, 2021 •

edited

Loading

codecov bot commented Mar 12, 2021 •

edited

Loading