feat: throw if aborted while rendering section #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcandeia
approved these changes
Jul 19, 2024
igorbrasileiro
changed the title
igorbrasileiro
changed the title
tlgimenes
added a commit
that referenced
this pull request
Jul 20, 2024
This reverts commit d658b31.
tlgimenes
pushed a commit
that referenced
this pull request
Jul 21, 2024
* Add fallback to section block * Throw if signal aborted on section render * Drop unnused import * Bump deps * Fix LoadingFallback types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables deco-cx/apps#721 (SingleDeferred.tsx) abort signal to render section fallback
Related to issue/milestone deco-cx/community#13