Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prop editing #132

Merged
merged 10 commits into from
Feb 29, 2024
Merged

feat: prop editing #132

merged 10 commits into from
Feb 29, 2024

Conversation

caroluchoa
Copy link
Contributor

@caroluchoa caroluchoa commented Feb 6, 2024

  • Use new widgets
  • Create new loaders to return icons to admin
  • Create adminIcons file where it has the necessary icons in a string format

Docs ready on: deco-sites/starting#269
PS: I don't think using string SVG file is the best solution. However, we were having trouble making icons from the store available for rendering in the admin project due to CORS errors and other issues. So, sending the icons as strings was the best solution we found at the moment. But this approach needs to be revisited.
Also, as mentioned on the docs, I've created a script on our storefront to transform icons into strings when deno task run is executed. The script is generate-icons.ts. This approach centralizes icon updates to sprites.svg only, avoiding the need for the user to update icons at two different files.

figma: https://www.figma.com/file/w0fmddDWNctUSlMqpgo67T/Beta%3A-new-navigation-%E2%80%A2-Q4.23?type=design&node-id=894-88372&mode=design&t=R9riu1daJMhk4uCR-0

Loom

prop-edit.mov

Reviews

  • Require a review from someone at the Engineering team.
  • If you have improved our UX with this PR, please send this to the Design team.

Copy link
Collaborator

@igorbrasileiro igorbrasileiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@igorbrasileiro
Copy link
Collaborator

Wdyt about creating a loader that returns sprites.svg with cors, so the admin can access it ?!

@caroluchoa
Copy link
Contributor Author

Wdyt about creating a loader that returns sprites.svg with cors, so the admin can access it ?!

@igorbrasileiro and I have agreed to postpone this for a bit

@caroluchoa caroluchoa merged commit 27bf368 into main Feb 29, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants