generated from deco-sites/fashion
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prop editing #132
Merged
Merged
feat: prop editing #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and reflect on adminIcons.ts
igorbrasileiro
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Wdyt about creating a loader that returns sprites.svg with cors, so the admin can access it ?! |
@igorbrasileiro and I have agreed to postpone this for a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs ready on: deco-sites/starting#269
PS: I don't think using string SVG file is the best solution. However, we were having trouble making icons from the store available for rendering in the admin project due to CORS errors and other issues. So, sending the icons as strings was the best solution we found at the moment. But this approach needs to be revisited.
Also, as mentioned on the docs, I've created a script on our storefront to transform icons into strings when deno task run is executed. The script is
generate-icons.ts
. This approach centralizes icon updates tosprites.svg
only, avoiding the need for the user to update icons at two different files.figma: https://www.figma.com/file/w0fmddDWNctUSlMqpgo67T/Beta%3A-new-navigation-%E2%80%A2-Q4.23?type=design&node-id=894-88372&mode=design&t=R9riu1daJMhk4uCR-0
Loom
prop-edit.mov
Reviews