Makefile Improvements #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dragorn421
reviewed
Jun 24, 2024
AngheloAlf
approved these changes
Jul 7, 2024
Mr-Wiseguy
approved these changes
Jul 7, 2024
ethteck
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few ideas I had regarding the Makefile that I think are improvements, and would allow ability to add a modern compiler much easier.
In particular using
$(CC)instead of$(WORKING_DIR)/$(CC)Edit: I've also changed the assembly file recipes to actually use
ASinstead ofCC, and forgcchave it usegcc -x assembler-with-cppforAS. For me this seems clearer what is going on, as it did take me a little bit to figure out that gcc was actually passing-x assembler-with-cppin the first place.