Update decred dependencies to latest master #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dcrwallet already requires go 1.20 as minimum version.
The sync status may change multiple times throughout the lifetime of the wallet, so ensure only the first one is closing the channel.
This removes the initial part of the testFilterBlockDisconnected, which causes a reorg all the way to genesis, in favor of only testing the smaller reorg of an already setup chain. The reorg to genesis will never actually happen in mainnet and SPV wallets have some trouble dealing with large reorgs all the way to genesis (specifically: the peers may get dropped due to too many orphan/sidechain headers being sent). In practice, decred reorgs are limited to a depth of 6 blocks due to PoS validation, thus exercising a 10 block reorg is sufficient for testing purposes.
The recently introduced disablerelaytx option from dcrwallet can be used by SPV wallets to reduce their bandwidth and cpu consumptions, when the users are not interested in mempool transactions. This is useful in particular to mobile wallets, for which these attributes are desirable.
This modifies the embedded wallet loader to pass along the aezeed encoded wallet birthday to newly created wallets. This offers a significant boost to the total setup time, in particular for new wallets that have not yet been used (i.e. new seeds), for which the initial account discovery and address discovery steps will now complete much faster. The birthday for new wallets has been modified to add a negative 24h offset, to ensure no reorgs could make the wallet miss transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates dcrd/dcrwallet dependencies to their latest master.
It also exposes the recently introduced
--disablerelaytxand wallet birthday options.This is currently a draft because it is waiting for some outstanding wallet PRs to be merged before the go.mod replacement directives can be removed.