Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update disjointset index preset & update x_request_id match #301

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

taloric
Copy link
Contributor

@taloric taloric commented Oct 31, 2024

  • update disjoint set init index to avoid index out of range
  • update server_sys_span match conditons , allow x_request_id link through 's-p' & 'c-p'

@taloric taloric changed the title fix: update disjointset index preset fix: update disjointset index preset & update x_request_id match Oct 31, 2024
@taloric taloric requested a review from sharang October 31, 2024 10:58
@taloric taloric linked an issue Oct 31, 2024 that may be closed by this pull request
@sharang sharang merged commit 99398aa into main Oct 31, 2024
@yujianweilai
Copy link

deepflow-app:latest已经使用,反馈一下使用结果:

  1. 之前的一些“出现断行”的业务场景,已经修复
    image
  2. 个别场景还存在“断行”的情况,不知是否还有优化的空间?
    image
    该traceid=ef067c1423364f508b0f41d9ee764f86.125.17307081665506201 ,对应的l7_flow_log ,见
    l7_flow_log_202411041914.csv
  3. 之前偶发的“能查询出链路信息,但是无法绘制火焰”的问题,暂时没有发现,持续观察中。
  4. 之前发现的个别服务存在sql调用,但是看不到mysql数据库网卡转换span的问题,试了一个业务场景,mysql网卡转换span显示正常。

@taloric taloric mentioned this pull request Nov 5, 2024
@taloric
Copy link
Contributor Author

taloric commented Nov 5, 2024

@yujianweilai
问题 2 我计算了下这份数据,和你这里渲染的结果差别较大,没发现此现象,可以看下是否提供错数据?

另建议在原 issue 反馈,避免问题发散

我用 问题 2 中提供的数据计算的渲染结果如下:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] 同一服务的入-出请求增加关联减少断线空行
3 participants