Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updateby rollingWAvg and more #106

Merged
merged 2 commits into from
May 16, 2023

Conversation

stanbrub
Copy link
Collaborator

@stanbrub stanbrub commented May 15, 2023

Added more updateby tests. Added scaling where helpful.

  • RollingWAvg
  • Exponential Moving Sum
  • Exponential Min/Max
  • RollingCount
  • RollingStd

Diff was not done because the Benchmark framework doesn't properly support NULLs. This will be done in a future story. (#40)

Attached is a run of the updateby package on the Benchmark server against the latest edge build (shows up as 0.25.0)

2022-05-15_bench_results_updateby.csv

@stanbrub stanbrub linked an issue May 15, 2023 that may be closed by this pull request
@stanbrub stanbrub requested a review from lbooker42 May 15, 2023 23:06
Copy link

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny documentation nits. Looks good overall.

import io.deephaven.benchmark.tests.standard.StandardTestRunner;

/**
* Standard tests for the updateBy table operation. Calculates a time-based exponential moving average for specified

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exponential moving sum (not average)


/**
* Standard tests for the updateBy table operation. Defines a tick-based rolling count. The result table contains
* additional columns with windowed rolling count1 for each specified column in the source table.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

counts (vs. count1)

@stanbrub stanbrub merged commit 25f933a into deephaven:main May 16, 2023
@stanbrub stanbrub deleted the updateby-rollingWAvg-and-more-2 branch May 16, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateBy RollingWAvg et al Tests
2 participants