Skip to content

Commit

Permalink
i2c: phytium: Convert to platform remove callback returning void
Browse files Browse the repository at this point in the history
0edb555: platform: Make platform_driver::remove() return void
cause build error, so convert .remove from int to void

Log:
drivers/i2c/busses/i2c-phytium-platform.c:351:19: error: initialization of ‘void (*)(struct platform_device *)’ from incompatible pointer type ‘int (*)(struct platform_device *)’ [-Werror=incompatible-pointer-types]
  351 |         .remove = phytium_i2c_plat_remove,
      |                   ^~~~~~~~~~~~~~~~~~~~~~~
drivers/i2c/busses/i2c-phytium-platform.c:351:19: note: (near initialization for ‘phytium_i2c_driver.<anonymous>.remove’)
  • Loading branch information
opsiff authored Nov 13, 2024
1 parent e29165c commit 0d43acb
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/i2c/busses/i2c-phytium-platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ static int phytium_i2c_plat_probe(struct platform_device *pdev)
return ret;
}

static int phytium_i2c_plat_remove(struct platform_device *pdev)
static void phytium_i2c_plat_remove(struct platform_device *pdev)
{
struct phytium_i2c_dev *dev = platform_get_drvdata(pdev);

Expand All @@ -306,8 +306,6 @@ static int phytium_i2c_plat_remove(struct platform_device *pdev)

if (!IS_ERR_OR_NULL(dev->rst))
reset_control_assert(dev->rst);

return 0;
}

#ifdef CONFIG_OF
Expand Down

0 comments on commit 0d43acb

Please sign in to comment.