Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements DefaultDataSink dynamic queue #166

Conversation

jumperson
Copy link
Contributor

@jumperson jumperson commented Jan 27, 2022

may be fix #163

@jumperson
Copy link
Contributor Author

@natario1
Thank you for developing a great library.
I would appreciate it if you could review the fix.

@jsnprofessor
Copy link

jsnprofessor commented Feb 13, 2023

@jumperson Thanks for the fix. It did fix BufferOverflowException but the resulting video has some artifacts. The first video is transcoded followed by the original. Transcoding with ROG Phone II Android 10.

transcoded.mp4
original.mp4

@natario1
Copy link
Member

I will investigate #163 and possibly reopen this later. Thanks a lot for your help!

@natario1 natario1 closed this Aug 11, 2024
@natario1 natario1 reopened this Aug 14, 2024
Copy link
Member

@natario1 natario1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@natario1 natario1 merged commit c962e8f into deepmedia:main Sep 7, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow in DefaultDataSink.enqueue (slow audio format)
3 participants