Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix macos library name #1566

Merged
merged 1 commit into from
Mar 12, 2022
Merged

fix macos library name #1566

merged 1 commit into from
Mar 12, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 11, 2022

The library type was changed from SHARED to MODULE in #1384.

Fixes errors in conda-forge/deepmd-kit-feedstock#31

The library type was changed from SHARED to MODULE in deepmodeling#1384.

Fixes errors in conda-forge/deepmd-kit-feedstock#31
@codecov-commenter
Copy link

Codecov Report

Merging #1566 (1b5c354) into devel (69989b4) will decrease coverage by 11.75%.
The diff coverage is n/a.

❗ Current head 1b5c354 differs from pull request most recent head 23b9234. Consider uploading reports for the commit 23b9234 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1566       +/-   ##
===========================================
- Coverage   76.03%   64.28%   -11.76%     
===========================================
  Files          93        5       -88     
  Lines        7729       14     -7715     
===========================================
- Hits         5877        9     -5868     
+ Misses       1852        5     -1847     
Impacted Files Coverage Δ
deepmd/env.py
deepmd/__main__.py
deepmd/cluster/__init__.py
deepmd/utils/graph.py
deepmd/utils/convert.py
deepmd/__init__.py
deepmd/loss/tensor.py
deepmd/infer/data_modifier.py
deepmd/fit/ener.py
deepmd/entrypoints/config.py
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69989b4...23b9234. Read the comment docs.

@wanghan-iapcm wanghan-iapcm merged commit 70fcda6 into deepmodeling:devel Mar 12, 2022
@njzjz njzjz deleted the macos branch March 12, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants