Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ase.py: To avoid errors in writing to the .extxyz format from an Atom object coverted from .npy with dpdata. #717

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ZhouXY-PKU
Copy link
Contributor

@ZhouXY-PKU ZhouXY-PKU commented Sep 4, 2024

Stress store in an ASE SinglePointCalculator should be an 1×6 array, not be a 3×3 matrix.

Summary by CodeRabbit

  • New Features
    • Enhanced stress value calculations to provide a more structured representation of the stress tensor components in results.
    • Improved handling of stress tensor components for better accuracy in subsequent calculations.

…an Atom object coverted from .npy with dpdata.

Stress store in an ASE SinglePointCalculator should be an 1×6 array, not be a 3×3 matrix.

Signed-off-by: Levi Zhou  <[email protected]>
Copy link

coderabbitai bot commented Sep 4, 2024

Walkthrough

Walkthrough

The changes in the to_labeled_system method of the dpdata/plugins/ase.py file involve a modification in the calculation and storage of stress values in the results dictionary. The stress is now computed as a structured NumPy array that includes both diagonal and off-diagonal components of the stress tensor, improving the organization of stress data.

Changes

Files Change Summary
dpdata/plugins/ase.py Updated the to_labeled_system method to calculate stress as a structured NumPy array, incorporating specific components of the stress tensor. No changes to the function signature.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9de727e and 9a92619.

Files selected for processing (1)
  • dpdata/plugins/ase.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • dpdata/plugins/ase.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codspeed-hq bot commented Sep 4, 2024

CodSpeed Performance Report

Merging #717 will not alter performance

Comparing ZhouXY-PKU:patch-1 (9a92619) with master (c685e62)

Summary

✅ 2 untouched benchmarks

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (c685e62) to head (9a92619).
Report is 33 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #717   +/-   ##
=======================================
  Coverage   84.50%   84.51%           
=======================================
  Files          81       81           
  Lines        7152     7153    +1     
=======================================
+ Hits         6044     6045    +1     
  Misses       1108     1108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stress33[1][1],
stress33[2][2],
stress33[1][2],
stress33[2][0],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 0,2 though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But actually the value of (2,0) always equals to (0,2)......changing it is okay.

@njzjz njzjz changed the base branch from master to devel September 4, 2024 13:49
@njzjz njzjz merged commit 976cf16 into deepmodeling:devel Sep 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants