improve the way to determine whether a variable is None #4782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUAN-ZX
requested review from
tjruwase,
mrwyattii,
awan-10,
cmikeh2 and
arashb
as code owners
RUAN-ZX
changed the title
|
@tjruwase, would you please review this pr and launch ut workflow ? It solves a bug of type mismatch and improve the way of |
tjruwase
approved these changes
Dec 7, 2023
mrwyattii
approved these changes
Dec 8, 2023
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
…4782) refactor: improve the way to decide whether a variable is None fix: type mismatch for judging if current accelerator is in SUPPORTED_ACCELERATOR_LIST --------- Co-authored-by: ryan <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: improve the way to decide whether a variable is None
fix: type mismatch for judging if current accelerator is in SUPPORTED_ACCELERATOR_LIST