fix hostname -I for macOS #6497 #6990
Open
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUGFIX for Apple Silicon hostname
loadams
reviewed
Feb 3, 2025
| master_addr = result.decode('utf-8').split()[0] | ||
| except subprocess.CalledProcessError: # hostname -I not available (e.g. on macOS) | ||
| import socket | ||
| master_addr = socket.gethostbyname(socket.gethostname()) |
There was a problem hiding this comment.
@fitzjalen - wanted to check that this is working for you, I get different results when running this:
hostname -I
172.28.29.141
vs
>>> import socket
>>> socket.gethostbyname(socket.gethostname())
'127.0.1.1'
Could you share the output of these that it is working on your system?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGFIX for Apple Silicon hostname #6497