[Draft] Add support for seq split in Domino #961
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same thing here as deepspeedai/DeepSpeed#7111, I just changed it to draft branch, thank you! |
GuanhuaWang
changed the title
GuanhuaWang
reviewed
Mar 5, 2025
| @@ -206,6 +206,8 @@ def parse_args(): | |||
| help='Report loss and timing interval.') | |||
| parser.add_argument('--save-interval', type=int, default=None, | |||
| help='Number of iterations between checkpoint saves.') | |||
| parser.add_argument('--input-split-dim', type=str, default='batch', | |||
| help='Dimension for input split.') | |||
There was a problem hiding this comment.
Dimension for input split. ['batch', 'seq']
GuanhuaWang
reviewed
Mar 5, 2025
| @@ -127,6 +127,7 @@ def __init__(self, | |||
| self.init_method = config.init_method | |||
| self.encoder_attn_mask_type = encoder_attn_mask_type | |||
| self.encoder_hidden_state = None | |||
| self.input_split_dim = config.input_split_dim | |||
There was a problem hiding this comment.
one possible thing we need to verify and check is if split dim is seq, can we still initialize the same rope embedding, which is a very popular position embedding function. because for rope:
if self.use_rotary_position_embeddings:
self.seq_length = args.seq_length
our self.seq_length may not be correct ( ours might be half of original seq_length).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.