ForceApply #11
Closed
ForceApply #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failing if there's a conflict like .Apply()
cmwylie19
requested changes
Sep 28, 2023
Comment on lines
+145
to
+146
| let result = await kube.ForceApply({ metadata: { name: "fake" }, spec: { priority: 3 } }); | ||
| result = await kube.ForceApply({ metadata: { name: "fake" }, spec: { priority: 3 } }); |
There was a problem hiding this comment.
Suggested change
| let result = await kube.ForceApply({ metadata: { name: "fake" }, spec: { priority: 3 } }); | |
| result = await kube.ForceApply({ metadata: { name: "fake" }, spec: { priority: 3 } }); | |
| let result = await kube.ForceApply({ metadata: { name: "fake" }, spec: { priority: 3 } }); |
There was a problem hiding this comment.
result seems duplicated.
Another question I had @bdw617, is will this trigger a conflict? I didn't see a change in field that another manager also claims to manage? I am new to SSA so i could be wrong.
There was a problem hiding this comment.
yeah, I was lazy, let me update it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added .ForceApply(), that will overwrite (when it can) versus failing if there's a conflict like .Apply().
Functions exactly like Apply() but will set this:
url.searchParams.set("force", opts.method === "FORCEAPPLY" ? "true" : "false");
This saves the user from using a JSON patch with .Patch() and letting us use SSA