Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests for coverage #17

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

bdw617
Copy link
Contributor

@bdw617 bdw617 commented Oct 2, 2023

fix: filters for field and label selectors weren't tested. also added a test for a Kind without a version.

@bdw617 bdw617 requested a review from jeff-mccoy October 2, 2023 20:58
@bdw617 bdw617 added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Oct 2, 2023
@bdw617 bdw617 changed the title added tests for coverage fix: tests for coverage Oct 2, 2023
Copy link
Member

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll open a new PR for the filters issue this doesnt address

@jeff-mccoy jeff-mccoy merged commit 3a29afe into main Oct 3, 2023
8 of 10 checks passed
@jeff-mccoy jeff-mccoy deleted the improve-test-converage-for-util branch October 3, 2023 03:06
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

🎉 This PR is included in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants