Merge branch 'main' into fix-annotations

defenseunicorns · Oct 7, 2024 · ff2b52f · ff2b52f
2 parents ca2face + b9f6413
commit ff2b52f
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 19 deletions.
diff --git a/src/leapfrogai_ui/package-lock.json b/src/leapfrogai_ui/package-lock.json
diff --git a/src/leapfrogai_ui/package.json b/src/leapfrogai_ui/package.json
@@ -29,7 +29,7 @@
     "@playwright/test": "^1.47.2",
     "@sveltejs/adapter-auto": "^3.2.4",
     "@sveltejs/adapter-node": "^5.2.2",
-    "@sveltejs/kit": "^2.5.26",
+    "@sveltejs/kit": "^2.6.2",
     "@tailwindcss/typography": "^0.5.15",
     "@testing-library/jest-dom": "^6.5.0",
     "@testing-library/svelte": "^5.2.1",

diff --git a/src/leapfrogai_ui/src/lib/components/Message.svelte b/src/leapfrogai_ui/src/lib/components/Message.svelte
@@ -214,7 +214,6 @@
             tabindex="0"
           >
             <EditOutline />
-            <span class="sr-only">Edit Message</span>
           </IconButton>
         {/if}
         {#if message.role !== 'user'}
@@ -246,7 +245,6 @@
             tabindex="0"
           >
             <RedoOutline />
-            <span class="sr-only">Regenerate Message</span>
           </IconButton>
         {/if}
       </div>

diff --git a/src/leapfrogai_ui/tests/assistants.test.ts b/src/leapfrogai_ui/tests/assistants.test.ts
@@ -347,9 +347,10 @@ test('displays a toast if there is an error deleting an assistant and response i
   await deleteAssistantWithApi(assistant.id, openAIClient);
 });
 
+// TODO - these tests stopped working, need to be fixed
 // Note - these error cases do not test all edge cases. ex. completed response comes back empty, /chat/assistants
 // partially completes then fails, stream fails, etc...
-test('displays an error toast if /chat/assistants throws while getting a response from an assistant', async ({
+test.skip('displays an error toast if /chat/assistants throws while getting a response from an assistant', async ({
   page,
   openAIClient
 }) => {
@@ -369,7 +370,7 @@ test('displays an error toast if /chat/assistants throws while getting a respons
   await expect(page.getByText(ASSISTANT_ERROR_MSG)).toBeVisible();
 });
 
-test('displays an error toast if /chat/assistants returns a 500 when getting a response from an assistant', async ({
+test.skip('displays an error toast if /chat/assistants returns a 500 when getting a response from an assistant', async ({
   page,
   openAIClient
 }) => {
@@ -389,7 +390,7 @@ test('displays an error toast if /chat/assistants returns a 500 when getting a r
   await expect(page.getByText(ASSISTANT_ERROR_MSG)).toBeVisible();
 });
 
-test('displays an error toast if /chat/assistants returns a 200 with no body when getting a response from an assistant', async ({
+test.skip('displays an error toast if /chat/assistants returns a 200 with no body when getting a response from an assistant', async ({
   page,
   openAIClient
 }) => {

diff --git a/src/leapfrogai_ui/tests/rag.test.ts b/src/leapfrogai_ui/tests/rag.test.ts
@@ -89,7 +89,7 @@ test('it can edit an assistant and remove a file', async ({ page, openAIClient }
   await page.getByTestId('file-select-dropdown-btn').click();
   await fileSelectContainer.getByTestId(`${uploadedFile1.id}-checkbox`).uncheck();
   await page.getByRole('button', { name: 'Save' }).click();
-  await expect(page.getByText('Assistant Updated')).toBeVisible(); // also tests no assistant progress toast when no files
+  await expect(page.getByTestId('assistant-progress-toast')).toBeVisible();
 
   // Cleanup
   await deleteFileWithApi(uploadedFile1.id, openAIClient);