-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): assistants chat #1151
Merged
Merged
fix(ui): assistants chat #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
gregclark-defenseunicorns
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design Review passed
justinthelaw
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue with chatting with assistants where if you created a new one and went back to your previous assistant chat, the messages were gone.
Investigation revealed that there were some edge cases where server side fetched data was not in sync with client side store state.
This resulted in a large refactor to fetch data on the client side, instead of server side. This decision was made because the multiple pages depend on threads, files, and assistants and that data is modified in various places. Invalidating data at the root level whenever this data changed (triggering a load function that reloaded all threads, assistants, and files) would be too much overhead and network data. It's also complicated to keep the server fetched data in sync with the modified versions in our stores. It's simpler, cleaner, and less buggy to just fetch the data client side and manage it in the stores instead of trying to fetch it all server side, then update the stores.
I found some logical and testing issues during this refactor that had to be addressed for tests to pass, so there are several changes throughout, as well as new/modified tests.
Also fixes an issue where users could upload audio files to the file-managment page or assistants. Audio files are only allowed on the chat page without assistants.
Checklist before merging