-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): registry1 and package flavor patterns #889
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinthelaw
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
api
labels
Aug 7, 2024
justinthelaw
added this to the Next (M11) - Conformance | Stability | Documentation milestone
Aug 7, 2024
justinthelaw
changed the title
(DO NOT MERGE) feat(api): registry1 package flavor
[DO NOT MERGE] feat(api): registry1 package flavor
Aug 7, 2024
✅ Deploy Preview for leapfrogai-docs canceled.
|
justinthelaw
changed the title
[DO NOT MERGE] feat(api): registry1 package flavor
[DO NOT MERGE] feat(api): registry1 and package flavor patterns
Aug 7, 2024
This was
linked to
issues
Aug 7, 2024
justinthelaw
changed the title
[DO NOT MERGE] feat(api): registry1 and package flavor patterns
feat(api): registry1 and package flavor patterns
Aug 7, 2024
justinthelaw
added
the
blocked 🛑
Something needs to happen before this issues is worked
label
Aug 8, 2024
This was
unlinked from
issues
Aug 12, 2024
This was
unlinked from
issues
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
blocked 🛑
Something needs to happen before this issues is worked
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Caution
DO NOT MERGE
Creates a Registry1 flavor for the LeapfrogAI API and improves documentation on how to use the API. Refactors Make recipes, values files, and other tangential components that are affected by this new multi-Zarf-package-flavor enhancement.
As a side effect of this change, closer alignment to UDS Common and UDS CLI standards and documentation practices were implemented to improve repeatability and developer experience.
This PR closes several issues, and is a direct child of the Epic described here: #750
BREAKING CHANGES
upstream
flavor to ALL Zarf packages, as the defaultCHANGES
Builds:1
registry1
flavor to the API packageregistry1
flavor forapi
andkiwigrid
, does not changeapi-migrations
yetunicorn
flavor placeholder to the API Zarf packageDocumentation:2
markdownlint
configuration files for*.md
documentation lintingTests:3
Footnotes
chore(release): correct ghcr repository directory #703 feat: leapfrogai api registry1 flavor #730 ↩ ↩2
chore(docs): markdown and docs linter #711 chore(api): Document supported file types for RAG #754 ↩
chore(lint): commit and label lint #709 chore(lint): uds and zarf lints #706 ↩