-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(adr): add ADR for E2E intent and design #432
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for lula-docs canceled.
|
- A `component definition` will perform the mapping of one-to-many standards/benchmarks/policies to one-to-many system components | ||
- Where possible, a single `component definition` should focus on a single system component | ||
- A `system security plan` will aggregate the collection of one-to-many `component definitions` into a single system definition | ||
- An `assessment plan` will aggregate one-to-many `component-definitions` into a plan with depth of control satisfaction based upon many layers of implementation for any given control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be the assessment plan will aggregate one-to-one system-security-plan
?
Thinking the assessment plan links to the ssp which links to the components. It technically assess the admin controls too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question - it may vey well be.
If the data flow is: component -> assessment plan -> system security plan
then yes that may be the case?
But I see a lot of overlap between components and SSP that makes me wonder about this workflow.
I'm going to look at this ADR again - I don't want to focus too much on the solutioning (hence why there was mention of many possible workflows) - But I think I need to highlight another point - which is that we might use components to generate an AP & SSP - but when the generation of say the AP detects that an SSP exists - it can establish context sharing. So as you implement each model - you may have cross model connections being made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"we might use components to generate an AP & SSP - but when the generation of say the AP detects that an SSP exists - it can establish context sharing. So as you implement each model - you may have cross model connections being made."
^ This, 100% agree. I also agree there are several possibilities for our workflows.
I think OSCAL Data Flow viewpoint is
graph TD;
A[Component Definition]
B[Assessment Plan]
C[System Security Plan]
D[Assessment Results]
E[POAM]
A --> C --> B --> D --> E
This may show it a little better too. https://pages.nist.gov/OSCAL/resources/concepts/layer/assessment/assessment-results/#key-concepts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of the mermaid flow chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think the one thing thing missing for me was discussion of evaluate
and how that fits into the end-to-end
That's a good mention. Focusing on artifact strategy here - but am open to including process if we believe it is necessary and would warrant a later ADR? |
I was thinking that since it evaluates two assessment-results, it is kind of reliant on OSCAL data and would potentially fit within an E2E picture? But I realize that it's not actually producing any kind of recognized OSCAL data so maybe doesn't actually make sense here. I was more just thinking about enumerating the use case for evaluate being relevant in the full end to end. I'm good to table the question on evaluate if it's out of scope for this |
Description
ADR for Lula E2E OSCAL design decisions and expectations.
To follow this ADR:
Related Issue
Relates to #431
Type of change
Checklist before merging