-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compose): template files during compose operations #686
feat(compose): template files during compose operations #686
Conversation
Noticed when testing that case-sensitive keys in |
…ring-persistent-writes
…ring-persistent-writes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review - getting a baseline understanding and a super minor fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review cont - Can we run lula internal gen-cli-docs
to update docs?
Description
Sorry for another massive PR - just to hopefully make the review a little easier going to try and enumerate the bigger things that changed here -
src/cmd/common/viper.go
-> made TemplateConstants and TemplateVariables global. Don't love this pattern but in the interest of not totally redoing this and not having to call "GetTemplateConfig" in every template-able workflow, just ideally will run this once inInitViper
src/cmd/tools/compose.go
-> refactored this command a bit to enable just calling the cmd (mostly for testing, but also I feel like returning the command is a better pattern?)src/pkg/common/composition
-> added the CompositionContext so it would more easily pass the TemplateRenderer, which basically get used in the sub functions to do the template rendering pieces. Includesoptions
to set those values, I am a fan of this pattern but may not have really done this the best way so if some of this is an anti-pattern lmksrc/pkg/common/network
-> network fetch options to allow for a set base directory, instead of doing the cwd changes. This is pretty coupled to the composition implementation but could possibly be split to a separate PR, it just wouldn't fix the UDS issue on it's ownRelated Issue
Fixes #642
Type of change
Checklist before merging