-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add brew install for lula #707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor future proofing commands but i'd also like to make a request:
goreleaser check
is returning errors and deprecations. While we're here I'd like to expand scope a small amount such that we have a repeatable process for these kinds of updates.
- Ensure the configuration is valid per
goreleaser check
- Document these checks in our release process (if applicable)
Besides that - as a practice I'd like to start capturing "how does a reviewer perform review of these changes" in our PR descriptions -> I'll work this into a PR template.
Added a GitHub Action that will run GoReleaser check on any pushes or PRs that contain a change to the .goreleaser.yaml file. Also tweaked the wording a bit in our release documentation to call out the brew info and the action. We don't go too in-depth into distros. |
Description
Added Brew release configuration. This should create the release inside of the Defense Unicorns Brew repo. Permissions were previously setup.
A separate issues exists for updating the documentation after a release has been cut and testing has bee conducted. #321
This issue would be a follow on after a release has been made.
Related Issue
Fixes #
#702
Type of change
Checklist before merging