Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add brew install for lula #707

Merged
merged 4 commits into from
Oct 7, 2024
Merged

feat: add brew install for lula #707

merged 4 commits into from
Oct 7, 2024

Conversation

CloudBeard
Copy link
Collaborator

Description

Added Brew release configuration. This should create the release inside of the Defense Unicorns Brew repo. Permissions were previously setup.

A separate issues exists for updating the documentation after a release has been cut and testing has bee conducted. #321

This issue would be a follow on after a release has been made.

Related Issue

Fixes #
#702

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@CloudBeard CloudBeard self-assigned this Oct 4, 2024
@CloudBeard CloudBeard requested a review from a team as a code owner October 4, 2024 13:31
@CloudBeard CloudBeard linked an issue Oct 4, 2024 that may be closed by this pull request
1 task
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor future proofing commands but i'd also like to make a request:

goreleaser check is returning errors and deprecations. While we're here I'd like to expand scope a small amount such that we have a repeatable process for these kinds of updates.

  • Ensure the configuration is valid per goreleaser check
  • Document these checks in our release process (if applicable)

Besides that - as a practice I'd like to start capturing "how does a reviewer perform review of these changes" in our PR descriptions -> I'll work this into a PR template.

.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
@CloudBeard
Copy link
Collaborator Author

Added a GitHub Action that will run GoReleaser check on any pushes or PRs that contain a change to the .goreleaser.yaml file.

Also tweaked the wording a bit in our release documentation to call out the brew info and the action. We don't go too in-depth into distros.

@brandtkeller brandtkeller merged commit fd1d3e0 into main Oct 7, 2024
6 checks passed
@brandtkeller brandtkeller deleted the 702-brew-install-lula branch October 7, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Brew Install Lula
2 participants