Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes): support running both create resources and resources in the kubernetes spec #714

Conversation

meganwolf0
Copy link
Collaborator

@meganwolf0 meganwolf0 commented Oct 8, 2024

Description

Adds operations to support create -> wait -> read

  • Fixed a bug that I found with the ExecuteWait (apparently the object returned from validateAndGetGVR doesn't have the correct Group value, so more learning possibly there as to why - so this had passed with a basic "pod" but not with something more complex like a deployment)
  • Re-arranged KubernetesDomain GetResources to evaluate CreateResources -> Wait -> Resources, combining the create and resources into a final types.DomainResources. Based on the combining (just a simple map merge) the keys (names) between the two need to be unique
  • Finally, renamed types -> spec following the discussion on naming clarity

Related Issue

Fixes #531

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@meganwolf0 meganwolf0 changed the title 531 support running both create resources and resources in the kubernetes spec feat(kubernetes): support running both create resources and resources in the kubernetes spec Oct 9, 2024
@meganwolf0 meganwolf0 force-pushed the 531-support-running-both-create-resources-and-resources-in-the-kubernetes-spec branch from c090cc6 to 64734c7 Compare October 10, 2024 00:37
@meganwolf0 meganwolf0 marked this pull request as ready for review October 10, 2024 11:59
@meganwolf0 meganwolf0 requested a review from a team as a code owner October 10, 2024 11:59
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate identifying a bug and addressing it with a new test.

@brandtkeller brandtkeller merged commit 6839d20 into main Oct 11, 2024
5 checks passed
@brandtkeller brandtkeller deleted the 531-support-running-both-create-resources-and-resources-in-the-kubernetes-spec branch October 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Support running both create-resources and resources in the kubernetes-spec
2 participants