Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): assessment results view updates #725

Closed
wants to merge 41 commits into from

Conversation

meganwolf0
Copy link
Collaborator

@meganwolf0 meganwolf0 commented Oct 10, 2024

Description

Updated assessment results model view

  • Sortable, filterable tables to show both findings and observations
  • Includes "comparison" routine that will compare any two findings selected -> Didn't wire up evaluate here (yet). Probably more fact-finding needed as to the workflow for calling it, but a blanket comparison made sense to me
  • Re-wired a bit of the architecture for calling the Models (trying to be idiomatic with bubbletea and use events as much as possible) - Plus was trying to address routines running unnecessarily + extra lag
  • Docs!

Related Issue

Fixes #723

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@meganwolf0 meganwolf0 changed the title 723 console assessment results view updates feat(console): assessment results view updates Oct 15, 2024
@meganwolf0 meganwolf0 marked this pull request as ready for review October 18, 2024 12:55
@meganwolf0 meganwolf0 requested a review from a team as a code owner October 18, 2024 12:56
@brandtkeller
Copy link
Member

Expecting conflicts and possibly some updates to fix a few linting issues that may or may not be still present.

@meganwolf0
Copy link
Collaborator Author

Expecting conflicts and possibly some updates to fix a few linting issues that may or may not be still present.

should be fixed! made a couple mods to pass go lint in the profile work too, but don't think it changed anything meaningful

@brandtkeller
Copy link
Member

Closing as included in other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

(Console): Assessment Results View Updates
2 participants