Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scan): integrate KICS scanning into PR pipelines #751

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

brandtkeller
Copy link
Member

@brandtkeller brandtkeller commented Oct 18, 2024

Description

Integration of kics static analysis for IaC (kubernetes)

Decided to ignore files explicitly as opposed to a configuration file. I don't hold a strong opinion here but I didn't want to potentially flag entire directories for which we may want some insights. There is an argument for blanket ignoring the whole of test/demo directories and still scanning src.

Related Issue

Resolves #750

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@brandtkeller brandtkeller self-assigned this Oct 18, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@brandtkeller brandtkeller marked this pull request as ready for review October 19, 2024 03:53
@brandtkeller brandtkeller requested a review from a team as a code owner October 19, 2024 03:53
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this as it is, though I'd like to suggest for the future that we move our test directory layout to something more idiomatic - all extra test data files in a directory called testdata (nested in a directory under testdata works too) and exclude that pattern.

@brandtkeller brandtkeller merged commit 0112462 into main Oct 22, 2024
10 checks passed
@brandtkeller brandtkeller deleted the 750_kics_integration branch October 22, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[scanning] Integrate KICS scanning into pipelines
2 participants