feat: refactor action into a interface #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor the actionrunner and actioncfg into a interface to help create unit tests. Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
requested review from
UncleGedd,
jeff-mccoy,
decleaver and
mjnagel
as code owners
UncleGedd
reviewed
Mar 20, 2024
| ) | ||
|
|
||
| // ActionRunner defines the interface for running actions. | ||
| type ActionRunner interface { |
There was a problem hiding this comment.
I think the abstraction created by the interface doesn't quite make sense. I think we'll only ever have Zarf action runners implement this interface. Understood this makes mocking in unit tests a bit easier but I don't that's worth the extra abstraction.
naveensrinivasan
force-pushed
the
naveen/feat/refactor-zarf-deps-injection
branch
from
d78f7dd
to
e1682ad
Compare
Closing this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging