Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: do not try to remove something that is not there #210

Merged
merged 1 commit into from
Dec 12, 2024
Merged

chore: do not try to remove something that is not there #210

merged 1 commit into from
Dec 12, 2024

Conversation

cmwylie19
Copy link
Contributor

do not try to remove an item that does not exist bc Kubernetes will not let you

btlghrants
btlghrants approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could catch / silently continue in the case that something's already removed, but... this should unblock the e2es, so LGTM.

@btlghrants btlghrants merged commit 919c37e into main Dec 12, 2024
2 checks passed
@btlghrants btlghrants deleted the removeItemAndWait branch December 12, 2024 20:05
@cmwylie19
Copy link
Contributor Author

Would be nice if we could catch / silently continue in the case that something's already removed, but... this should unblock the e2es, so LGTM.

Yes, I agree. defenseunicorns/pepr#1570 Here is the resulting issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btlghrants btlghrants btlghrants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmwylie19 @btlghrants