Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependencies #1244

Open
2 of 11 tasks
samayer12 opened this issue Oct 9, 2024 · 0 comments
Open
2 of 11 tasks

Remove circular dependencies #1244

samayer12 opened this issue Oct 9, 2024 · 0 comments

Comments

@samayer12
Copy link
Collaborator

samayer12 commented Oct 9, 2024

Describe what should be investigated or refactored

Pepr has 18 circular dependencies. These can be the source of runtime errors, initialization order issues, and it complicates code structure. Furthermore, this makes things difficult to debug and can be the source of memory leaks or inconsistent behavior across environments.

We should restructure the code so that these circular dependencies are removed.

Definition of Done

  • There are less than 18 circular dependencies in the project.
  • The tolerance threshold in CI/CD's Circular Dependency Check step is lowered.

Circular dependencies can be addressed over the course of several PRs if necessary, you do not need to resolve all of them at once.

Additional context

Calculate the current amount of circular dependencies with: npx madge -c --extensions ts src/

Related issue to this broader issue are:

@samayer12 samayer12 added the good first issue Good for newcomers label Oct 9, 2024
@cmwylie19 cmwylie19 removed the good first issue Good for newcomers label Oct 15, 2024
@cmwylie19 cmwylie19 added this to the v0.39.0 milestone Oct 23, 2024
@cmwylie19 cmwylie19 moved this from 🆕 New to 📋 Backlog in Pepr Project Board Oct 23, 2024
@schaeferka schaeferka self-assigned this Oct 23, 2024
@schaeferka schaeferka moved this from 📋 Backlog to 🏗 In progress in Pepr Project Board Oct 23, 2024
@schaeferka schaeferka linked a pull request Oct 23, 2024 that will close this issue
5 tasks
@cmwylie19 cmwylie19 removed this from the v0.39.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants