You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what should be investigated or refactored
Pepr has 18 circular dependencies. These can be the source of runtime errors, initialization order issues, and it complicates code structure. Furthermore, this makes things difficult to debug and can be the source of memory leaks or inconsistent behavior across environments.
We should restructure the code so that these circular dependencies are removed.
Definition of Done
There are less than 18 circular dependencies in the project.
The tolerance threshold in CI/CD's Circular Dependency Check step is lowered.
Circular dependencies can be addressed over the course of several PRs if necessary, you do not need to resolve all of them at once.
Additional context
Calculate the current amount of circular dependencies with: npx madge -c --extensions ts src/
Related issue to this broader issue are:
The content you are editing has changed. Please copy your edits and refresh the page.
Describe what should be investigated or refactored
Pepr has 18 circular dependencies. These can be the source of runtime errors, initialization order issues, and it complicates code structure. Furthermore, this makes things difficult to debug and can be the source of memory leaks or inconsistent behavior across environments.
We should restructure the code so that these circular dependencies are removed.
Definition of Done
Circular Dependency Check
step is lowered.Circular dependencies can be addressed over the course of several PRs if necessary, you do not need to resolve all of them at once.
Additional context
Calculate the current amount of circular dependencies with:
npx madge -c --extensions ts src/
Related issue to this broader issue are:
Tasks
lib/assets/index.ts > lib/assets/deploy.ts
#1623lib/assets/index.ts > lib/assets/deploy.ts > lib/assets/pods.ts
#1624lib/core/module.ts > lib.ts > lib/core/capability.ts
#1625lib/mutate-request.ts > lib/types.ts
#1626lib/types.ts > lib/validate-request.ts
#1627lib/core/module.ts > lib.ts
#1628lib/core/module.ts > lib/controller/index.ts
#1629lib/core/module.ts > lib/controller/index.ts > lib/processors/mutate-processor.ts
#1630lib/core/module.ts > lib/controller/index.ts > lib/processors/validate-processor.ts
#1631lib/assets/index.ts > lib/assets/deploy.ts > lib/assets/webhooks.ts
#1632lib/assets/index.ts > lib/assets/yaml.ts
#1633The text was updated successfully, but these errors were encountered: