Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix circular dependency between types and mutate-request #1326

Closed
wants to merge 6 commits into from

Conversation

schaeferka
Copy link
Contributor

Description

We would like to remove the circular dependency between types.ts and mutate-request.ts
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@schaeferka schaeferka self-assigned this Oct 23, 2024
@schaeferka schaeferka requested a review from a team as a code owner October 23, 2024 23:14
@schaeferka schaeferka linked an issue Oct 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (c1c0de7) to head (4cce379).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
+ Coverage   85.77%   85.78%   +0.01%     
==========================================
  Files          29       30       +1     
  Lines        1406     1407       +1     
  Branches      328      328              
==========================================
+ Hits         1206     1207       +1     
  Misses        182      182              
  Partials       18       18              
Files with missing lines Coverage Δ
src/lib/adjudicators.ts 100.00% <100.00%> (ø)
src/lib/filter.ts 94.73% <100.00%> (ø)
src/lib/finalizer.ts 100.00% <100.00%> (ø)
src/lib/mutate-request.ts 100.00% <100.00%> (ø)
src/lib/mutate-types.ts 100.00% <100.00%> (ø)
src/lib/types.ts 100.00% <ø> (ø)
src/lib/validate-request.ts 100.00% <100.00%> (ø)

.github/workflows/dependency-review.yml Show resolved Hide resolved
src/lib/mutate-request.ts Outdated Show resolved Hide resolved
src/lib/mutate-types.ts Outdated Show resolved Hide resolved
src/lib/types.ts Outdated Show resolved Hide resolved
@schaeferka
Copy link
Contributor Author

Closed and replaced with new PR to fix CI issue

@schaeferka schaeferka closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Remove circular dependencies
2 participants