Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate images from registry via Pepr (impl) #1262

Merged
merged 36 commits into from
Oct 31, 2024

Conversation

btlghrants
Copy link
Collaborator

Description

Working through how we might accomplish validating image signatures against pubkeys derived from the OCI registries that serve them.

Relates to #1240

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants self-assigned this Oct 11, 2024
@cmwylie19 cmwylie19 added the large large label Oct 16, 2024
Copy link

socket-security bot commented Oct 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 8.29 kB types
npm/[email protected] network 0 29.9 kB rubenverborgh
npm/[email protected] Transitive: environment, filesystem, network, shell +85 7.94 MB bdehamer

View full report↗︎

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 82.87671% with 25 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (ea99815) to head (f28aeff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/sdk/cosign.ts 81.39% 24 Missing ⚠️
src/sdk/heredoc.ts 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
+ Coverage   79.43%   79.69%   +0.25%     
==========================================
  Files          38       40       +2     
  Lines        1799     1945     +146     
  Branches      391      411      +20     
==========================================
+ Hits         1429     1550     +121     
- Misses        368      393      +25     
  Partials        2        2              
Files with missing lines Coverage Δ
src/sdk/heredoc.ts 94.11% <94.11%> (ø)
src/sdk/cosign.ts 81.39% <81.39%> (ø)

@btlghrants btlghrants marked this pull request as ready for review October 30, 2024 21:43
@btlghrants btlghrants requested a review from a team as a code owner October 30, 2024 21:43
@cmwylie19 cmwylie19 enabled auto-merge (squash) October 31, 2024 15:23
@cmwylie19 cmwylie19 merged commit 0971bd3 into main Oct 31, 2024
46 checks passed
@cmwylie19 cmwylie19 deleted the 1240_spike_img_sigs_from_reg_impl branch October 31, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large large
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants