Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: encourage return types in function definitions #1364

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

samayer12
Copy link
Collaborator

Description

Encourage non-test code to specify return types.

Related Issue

Hotifx

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (73341c6) to head (0057fd7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1364   +/-   ##
=======================================
  Coverage   79.53%   79.53%           
=======================================
  Files          39       39           
  Lines        1818     1818           
  Branches      387      396    +9     
=======================================
  Hits         1446     1446           
- Misses        343      370   +27     
+ Partials       29        2   -27     

see 7 files with indirect coverage changes

@samayer12 samayer12 marked this pull request as ready for review October 31, 2024 16:04
@samayer12 samayer12 requested a review from a team as a code owner October 31, 2024 16:04
Copy link
Contributor

@schaeferka schaeferka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This will help us track down these issues.

@samayer12 samayer12 changed the title Encourage return types in function definitions chore: encourage return types in function definitions Oct 31, 2024
@samayer12
Copy link
Collaborator Author

samayer12 commented Nov 4, 2024

This PR would make the logs pretty noisy, but is useful for the project. After discussion with @btlghrants, we're opted to put this on hold while we work on other outstanding refactors (e.g., #1248, #1371, #1250, #1247, etc). This PR will be suitable to revisit once the existing set of linter warnings are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants