Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: helpers.filterNoMatchReason() to use FilterChains #1387

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

btlghrants
Copy link
Collaborator

Description

Rewrite of the filterNoMatchReason() helper to use FilterChains & squash complexity warnings.

Related Issue

Fixes to #1371
Relates to #1248

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants self-assigned this Nov 5, 2024
@btlghrants btlghrants added this to the v0.39.0 milestone Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (e7d4f2f) to head (ddf9fac).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1387   +/-   ##
=======================================
  Coverage   79.53%   79.53%           
=======================================
  Files          39       40    +1     
  Lines        1818     1818           
  Branches      396      396           
=======================================
  Hits         1446     1446           
  Misses        343      343           
  Partials       29       29           
Files with missing lines Coverage Δ
src/lib/filter/filterNoMatchReason.ts 100.00% <100.00%> (ø)
src/lib/helpers.ts 96.64% <100.00%> (-0.54%) ⬇️
src/lib/watch-processor.ts 78.64% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant