Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused property in assets class #1647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samayer12
Copy link
Collaborator

Description

This PR removes the Assets.hash property and calculates the hash of a pepr module just before we need to provide that value to a consuming function. This will avoid potential issues with state and removes some dead code.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1638

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (b1b6709) to head (ed4eb10).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1647   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files          43       43           
  Lines        1979     1979           
  Branches      411      438   +27     
=======================================
  Hits         1611     1611           
  Misses        366      366           
  Partials        2        2           

@samayer12 samayer12 marked this pull request as ready for review January 10, 2025 21:15
@samayer12 samayer12 requested a review from a team as a code owner January 10, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Examine unused hash property in Assets class.
1 participant