Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate file parsing implementation #1663

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

samayer12
Copy link
Collaborator

Description

This PR provides a fix to feedback on #1642

Related Issue

Relates to #1640

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems legit. Like it. 👍

@btlghrants btlghrants merged commit 92ec7c3 into 1640_helm_templates_correspond Jan 15, 2025
7 checks passed
@btlghrants btlghrants deleted the 1640-resources-refactor branch January 15, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants