Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use daemonset for machineid instead of docker mount #8

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat: use daemonset for machineid instead of docker mount #8

merged 1 commit into from
Nov 9, 2023

Conversation

jeff-mccoy
Copy link
Member

@jeff-mccoy jeff-mccoy commented Nov 9, 2023 •
edited
Loading

Description

This replaces the problematic volume mount to generate a machine-id with a initcontainer daemonset to do the same without the janky docker mount issues. Also removed onRemote action that would break due to this Zarf issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@jeff-mccoy jeff-mccoy merged commit 2a49404 into main Nov 9, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachariahmiller zachariahmiller zachariahmiller approved these changes

@mikevanhemert mikevanhemert Awaiting requested review from mikevanhemert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeff-mccoy @zachariahmiller