Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a Ruby 3.2.3/bookworm image #21

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Build a Ruby 3.2.3/bookworm image #21

merged 2 commits into from
Mar 5, 2024

Conversation

sulami
Copy link
Contributor

@sulami sulami commented Feb 21, 2024

@sulami sulami force-pushed the ruby-3.2.3-bookworm branch 4 times, most recently from dc39aa8 to ebface8 Compare February 21, 2024 05:39
We've run into https://peps.python.org/pep-0668/, because we install a
bunch of Python packages via apt, and then try to also install the
awscli package via pip, which is not happy about having two sources of
packages.

We've always been doing this, so presumably it's safe to continue
doing so.
@sulami sulami force-pushed the ruby-3.2.3-bookworm branch from ebface8 to ccf5de2 Compare February 21, 2024 06:09
@sulami
Copy link
Contributor Author

sulami commented Mar 5, 2024

I've used this image to run a hats review app and confirmed that we don't have the GPayments issue anymore, my payment went through just fine.

image

@sulami sulami requested review from rramsden, showwin and zuccamia March 5, 2024 04:39
Copy link

@showwin showwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for my curiosity.

LGTM 👍

.github/workflows/build-rails-base.yml Show resolved Hide resolved
.github/workflows/build-rails-base.yml Show resolved Hide resolved
@sulami sulami added this pull request to the merge queue Mar 5, 2024
Merged via the queue into master with commit 5293ef8 Mar 5, 2024
12 checks passed
@sulami sulami deleted the ruby-3.2.3-bookworm branch March 5, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants