Update Makefile to stop referencing defs from parent repo and use mys… #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from package rather than build tree Signed-off-by: Radhika Jandhyala <[email protected]>
|
Would this have an effect on pipelines running this sample? |
|
Looks like the PR pipeline is green on this PR. So I dont believe so. |
vtikoo
reviewed
Sep 26, 2023
| $(MYST) mkext2 appdir rootfs | ||
| $(MYST) fssig --roothash rootfs > roothash | ||
| $(MYST) package-sgx --roothash=roothash package.pem config.json | ||
| @myst mkext2 appdir rootfs |
There was a problem hiding this comment.
I'd prefer having it without the @, that way we can see what commands were run in the pipeline logs. For end-user it is not a big difference in experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t from package rather than build tree