Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tst/job status #15

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Tst/job status #15

merged 9 commits into from
Oct 18, 2023

Conversation

pksorensen
Copy link
Member

Releasing endpoints and workflow state updates

@pksorensen
Copy link
Member Author

@thygesteffensen - You may review this PR :)

@pksorensen
Copy link
Member Author

  • In file WorkflowEngine.DemoApp/Startup.cs in lines 309 and 339, a null parameter was added to the TriggerAsync function call. Ensure that the function can handle null values properly.

  • In file WorkflowEngine.Core/ActionExecutor.cs, the variable names have been changed to follow naming conventions, using underscore _ for private fields. This is a good practice.

  • In file WorkflowEngine.Core/DefaultOutputsRepository.cs, there are changes to the function names and added functions. Ensure that these changes don't break existing functionality and the new functions are used appropriately.

  • In file WorkflowEngine.Core/ExpressionEngineExtensions.cs, changes have been made to the ResolveInputs function and an overload is added. The new function now correctly handles nested dictionaries, which could be an improvement if the original function wasn't handling them properly.

  • In file src/WorkflowEngine.Core/IOutputsRepository.cs, the AddAsync method has been renamed to AddTrigger, and the StartScope method has been commented out. Ensure that these changes don't break existing code where these methods are used.

  • In file src/WorkflowEngine.Core/TriggerContext.cs, a new property JobId has been added. Make sure this property is used correctly throughout the rest of the code.

  • In file src/WorkflowEngine.Hangfire/HangfireWorkflowExecutor.cs, the TriggerAsync function now takes an additional parameter. Ensure that this parameter is handled correctly in the function.

  • In file src/WorkflowEngine.Hangfire/ScheduledWorkflowTrigger.cs, a null parameter was added to the TriggerAsync function call. Ensure that the function can handle null values properly.

  • There are several new files and classes introduced (like ActionCompletedEvent.cs, Event.cs, EventType.cs, WorkflowFinishedEvent.cs). Ensure that these new classes are implemented correctly and used appropriately in the rest of the code.

@pksorensen pksorensen merged commit 9d5218b into master Oct 18, 2023
@pksorensen pksorensen deleted the tst/job-status branch October 18, 2023 10:29
@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thygesteffensen thygesteffensen Awaiting requested review from thygesteffensen

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pksorensen @thygesteffensen