Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSM common base image #134

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use CSM common base image #134

wants to merge 4 commits into from

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Jan 22, 2025

Description

Switch to the new CSM base image. The benefit is that it will now be possible to build images on non RHEL VMs and as a non root user.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1691

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built image and tested by running cert-csi.

@donatwork
Copy link
Contributor Author

Need to fix unit tests I guess.

@donatwork donatwork closed this Jan 22, 2025
@donatwork
Copy link
Contributor Author

Reopening PR. Unit tests coverage increase is being handled by other teams.

@donatwork donatwork reopened this Jan 23, 2025
@adarsh-dell
Copy link
Contributor

UT is failing, JFYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants