Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSM base image in builds #331

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Use CSM base image in builds #331

merged 6 commits into from
Jan 27, 2025

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Jan 24, 2025

Description

Use common CSM base image. This will allow building images on non RHEL systems, as well as being able to build without being root. Also speeds up image builds as the base image does not need to be rebuilt.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1707

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken // TechOps interfaces maintained.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built images using each image build target.
  • Installed driver using new image and ran cert-csi vio tests.

@donatwork donatwork changed the title Csm base image Use CSM base image in builds Jan 24, 2025
@donatwork donatwork marked this pull request as ready for review January 24, 2025 21:24
@donatwork donatwork requested a review from EvgenyUglov January 24, 2025 21:24
@donatwork donatwork merged commit 0a71e0c into main Jan 27, 2025
6 checks passed
@donatwork donatwork deleted the csm-base-image branch January 27, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants