test: add unit tests

service/utils/emcutils.go

@@ -182,12 +182,19 @@ func GetHostIP() ([]string, error) {
 
 // GetNFSClientIP is used to fetch IP address from networks on which NFS traffic is allowed
 func GetNFSClientIP(allowedNetworks []string) ([]string, error) {
-	var nodeIPs []string
 	addrs, err := net.InterfaceAddrs()
 	if err != nil {
 		return nil, err
 	}
+	nodeIPs, err := GetAddresses(allowedNetworks, addrs)
+	if err != nil {
+		return nil, err
+	}
+	return nodeIPs, nil
+}
 
+func GetAddresses(allowedNetworks []string, addrs []net.Addr) ([]string, error) {
+	var nodeIPs []string
 	networks := make(map[string]bool)
 	for _, cnet := range allowedNetworks {
 		networks[cnet] = false
@@ -213,7 +220,6 @@ func GetNFSClientIP(allowedNetworks []string) ([]string, error) {
 	if len(nodeIPs) == 0 {
 		return nil, fmt.Errorf("no valid IP address found matching against allowedNetworks %v", allowedNetworks)
 	}
-
 	return nodeIPs, nil
 }
 

service/utils/emcutils_test.go

@@ -0,0 +1,62 @@
+/*
+ Copyright © 2019 Dell Inc. or its subsidiaries. All Rights Reserved.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+      http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+package utils
+
+import (
+	"fmt"
+	"net"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetAddresses(t *testing.T) {
+
+	type errorTestCases struct {
+		description       string
+		addrs             []net.Addr
+		networkAddresses  []string
+		expectedAddresses []string
+		expectedError     string
+	}
+
+	for _, scenario := range []errorTestCases{
+		{
+			description:       "invalid",
+			addrs:             []net.Addr{&net.IPAddr{IP: []byte("192.168.2.1")}},
+			networkAddresses:  []string{"192.168.1.0/24"},
+			expectedAddresses: []string{},
+			expectedError:     fmt.Sprintf("no valid IP address found matching against allowedNetworks %v", []string{"192.168.1.0/24"}),
+		},
+		{
+			description:       "ok",
+			addrs:             []net.Addr{&net.IPAddr{IP: []byte("192.168.1.1")}},
+			networkAddresses:  []string{"192.168.1.0/24"},
+			expectedAddresses: []string{"192.168.1.1"},
+			expectedError:     "",
+		},
+	} {
+		t.Run(scenario.description, func(t *testing.T) {
+			addresses, err := GetAddresses(scenario.networkAddresses, scenario.addrs)
+			if err != nil {
+				assert.EqualError(t, err, scenario.expectedError)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, scenario.expectedAddresses, addresses)
+			}
+
+		})
+	}
+}