Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capacity value after resize to lower capacity #185

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

adamginna-dell
Copy link
Contributor

@adamginna-dell adamginna-dell commented Feb 9, 2024

Description

ControllerExpandVolume function in idempotency path change capacity to 0 and it cause error. This change fix capacity value after resize to lower capacity.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have commented my code, particularly in hard-to-understand areas
  • Backward compatibility is not broken

Test:

  • Unit test

Copy link
Contributor

@mdutka-dell mdutka-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamginna-dell adamginna-dell merged commit 0f10233 into main Feb 19, 2024
3 of 4 checks passed
@mjsdell mjsdell deleted the expand_volume_idempotecy_fix branch October 17, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants