DLPX-93370 Logrotate blackbox tests fail because /var/log/fluent/fluentd.log does not exist

[palash-gandhi]

Problem

Logrotate Blackbox tests failed with:

Error executing command "sudo logrotate /etc/logrotate.conf". Code: 1. Error: error: stat of /var/log/fluent/fluentd.log failed: No such file or directory.

I found that on both, develop and os-upgrade that log file is not created. However, with the new version of fluent-package, a logrotate configuration ships as part of the package:

delphix@dlpx-palashgandhi-os-upgrade-qar-162282-766f97e2:~$ dpkg -S /etc/logrotate.d/fluentd
fluent-package: /etc/logrotate.d/fluentd

delphix@dlpx-palashgandhi-os-upgrade-qar-162282-766f97e2:~$ cat /etc/logrotate.d/fluentd
/var/log/fluent/fluentd.log {
  daily
  rotate 30
  compress
  delaycompress
  notifempty
  create 640 _fluentd _fluentd
  sharedscripts
  postrotate
    pid=/var/run/fluent/fluentd.pid
    if [ -s "$pid" ]
    then
      kill -USR1 "$(cat $pid)"
    fi
  endscript
}

While I do think this is also an upstream bug (& filed fluent/fluent-package-builder#796), I feel our usage of fluentd might be to blame equally.

Solution

Add a missingok directive in the logrotate configuration for fluentd.

Testing Done

https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build/job/os-upgrade/job/pre-push/188/

delphix@pg-fluentd:~$ cat /etc/logrotate.d/fluentd
/var/log/fluent/fluentd.log {
  daily
  missingok
  rotate 30
  compress
  delaycompress
  notifempty
  create 640 _fluentd _fluentd
  sharedscripts
  postrotate
    pid=/var/run/fluent/fluentd.pid
    if [ -s "$pid" ]
    then
      kill -USR1 "$(cat $pid)"
    fi
  endscript
}

delphix@pg-fluentd:~$ sudo logrotate /etc/logrotate.conf
delphix@pg-fluentd:~$ echo $?
0

[palash-gandhi]

Replaced by https://github.com/delphix/dlpx-app-gate/pull/2870