DLPX-93502 LTS 24.04: delphix home directory requires 755 permissions to allow SFTP tests to pass #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to allow SFTP tests to pass PR URL: https://www.github.com/delphix/appliance-build/pull/796
palash-gandhi
force-pushed
the
dlpx/pr/palash-gandhi/111c0fbb-d0fc-4f88-b581-ecea3327e6a7
branch
from
07c9bdd to
9be2a06
Compare
david-mendez1
approved these changes
Feb 27, 2025
sebroy
requested changes
Feb 27, 2025
Comment on lines
+46
to
+51
| - name: Set 755 permissions on Delphix home directory | ||
| file: | ||
| path: /export/home/delphix | ||
| mode: 0755 | ||
| state: directory | ||
|
|
There was a problem hiding this comment.
CIS requires 750 permissions on home directories, so doing this will likely cause us heart-ache with CIS benchmarks. Instead, we should fix the test so that it doesn't try and put random files in the delphix user's home directory if it's not running as the delphix user.
There was a problem hiding this comment.
Makes sense, moved here: https://github.com/delphix/dlpx-app-gate/pull/2923. Closing this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A few unit tests failed like this: https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/integration-tests/job/split-precommit-dxostest/job/os-upgrade/22/testReport/com.delphix.appliance.server.dhm.test/SshManagerTest/uploadScriptWithSCP/
Solution
I compared the permissions on the
delphixuser's home directory and noticed a difference.On 20.04:
On 24.04:
Fixing the permissions allowed the unit tests to pass.
Testing Done
ab-pre-push: https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/10476/