chore: allow kernel::visitors to be public for Snapshot usage #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Snapshot.files() functrion is public but cannot be possibly used because the trait it relies upon isn't public. Oops! Signed-off-by: R. Tyler Croy <[email protected]> Sponsored-by: Scribd Inc
rtyler
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2966 +/- ##
==========================================
+ Coverage 72.26% 72.28% +0.02%
==========================================
Files 134 134
Lines 42973 42973
Branches 42973 42973
==========================================
+ Hits 31055 31065 +10
+ Misses 9931 9923 -8
+ Partials 1987 1985 -2 ☔ View full report in Codecov by Sentry. |
rtyler
requested review from
wjones127,
roeap,
hntd187 and
ion-elgreco
as code owners
ion-elgreco
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Snapshot.files() functrion is public but cannot be possibly used because the trait it relies upon isn't public. Oops!
Sponsored-by: Scribd Inc