Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin path tree #3092

Closed
wants to merge 1 commit into from
Closed

chore: pin path tree #3092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,6 @@ async-trait = { version = "0.1" }
futures = { version = "0.3" }
tokio = { version = "1" }
num_cpus = { version = "1" }

[patch.crates-io]
path-tree = { git = "https://github.com/viz-rs/path-tree.git", rev = "03f85c289cea8a3ae9ee7bcadba5633fb465b8da"} # pin to 0.8.1 due to nightly features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a dev only dependency? We cannot release with non-crates.io released packages in the manifests

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue, I couldn't see it in the dependency tree. Might only appear during tests

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can upgrade MSRV.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fundon that may be correct however I have been quite resistant to such rapid MSRV version upgrades for us in the past. For example we just had to bump to 1.81, and there's some rumblings about perhaps 1.82 which was only released about 2.5 months ago. An MSRV upgrade does not come with zero cost for our own build infrastructure nor for our users, so I try to make sure we're upgrading for "pretty good reasons".

In this case, i actually haven't seen the failure that @ion-elgreco was seeing when he looked at this. 🙈

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or lock version: =0.8.1, see https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or lock version: =0.8.1, see https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility

I did that actually but it still pulled in 0.8.2

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I caused you some trouble. 0.8.2 has been yanked. No changes required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I just saw the failure in a GitHub action, and also just noticed that @fundon you are the author of path-tree, and I also noticed that 0.8.2 is yanked 😆

grafik

@fundon I'm happy to help test out changes on older rusts if you want to give 0.8.3 a try, I can be found at rtyler on the delta-users slack or as rtyler on IRC (libera.chat)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I caused you some trouble. 0.8.2 has been yanked. No changes required.

No worries! Thanks for your help!

Loading