Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scalar extraction view types #3095

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: add view scalar extraction
Signed-off-by: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com>
ion-elgreco committed Jan 2, 2025
commit 93e1a1222556609bbc058cbb88a981cc43f5b809
10 changes: 8 additions & 2 deletions crates/core/src/kernel/scalars.rs
Original file line number Diff line number Diff line change
@@ -106,6 +106,10 @@ impl ScalarExt for Scalar {
.as_any()
.downcast_ref::<LargeStringArray>()
.map(|v| Self::String(v.value(index).to_string())),
Utf8View => arr
.as_any()
.downcast_ref::<StringViewArray>()
.map(|v| Self::String(v.value(index).to_string())),
Boolean => arr
.as_any()
.downcast_ref::<BooleanArray>()
@@ -122,6 +126,10 @@ impl ScalarExt for Scalar {
.as_any()
.downcast_ref::<FixedSizeBinaryArray>()
.map(|v| Self::Binary(v.value(index).to_vec())),
BinaryView => arr
.as_any()
.downcast_ref::<BinaryViewArray>()
.map(|v| Self::Binary(v.value(index).to_vec())),
Int8 => arr
.as_any()
.downcast_ref::<Int8Array>()
@@ -217,8 +225,6 @@ impl ScalarExt for Scalar {
| Dictionary(_, _)
| RunEndEncoded(_, _)
| Union(_, _)
| Utf8View
| BinaryView
| ListView(_)
| LargeListView(_)
| Null => None,
2 changes: 1 addition & 1 deletion python/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "deltalake-python"
version = "0.23.0"
version = "0.23.1"
authors = ["Qingping Hou <dave2008713@gmail.com>", "Will Jones <willjones127@gmail.com>"]
homepage = "https://github.com/delta-io/delta-rs"
license = "Apache-2.0"