feat: generated columns #3123
Open
feat: generated columns #3123
+778
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
ion-elgreco
force-pushed
the
feat/generated-columns
branch
2 times, most recently
from
be67624 to
e3f55b7
Compare
ion-elgreco
force-pushed
the
feat/generated-columns
branch
from
6efe64b to
18a3db8
Compare
ion-elgreco
force-pushed
the
feat/generated-columns
branch
2 times, most recently
from
4378bd9 to
173659c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
- Coverage 72.28% 72.13% -0.15%
==========================================
Files 134 134
Lines 42973 43262 +289
Branches 42973 43262 +289
==========================================
+ Hits 31062 31209 +147
- Misses 9923 10042 +119
- Partials 1988 2011 +23 ☔ View full report in Codecov by Sentry. |
ion-elgreco
force-pushed
the
feat/generated-columns
branch
2 times, most recently
from
91633d3 to
5fd0b6d
Compare
ion-elgreco
commented
Jan 13, 2025
| @@ -439,7 +438,11 @@ async fn write_execution_plan_with_predicate( | |||
| let checker = if let Some(snapshot) = snapshot { | |||
| DeltaDataChecker::new(snapshot) | |||
| } else { | |||
| DeltaDataChecker::empty() | |||
| debug!("Using plan schema to derive generated columns, since no shapshot was provided. Implies first write."); | |||
There was a problem hiding this comment.
A cleaner way maybe, is to check upstream whether an metadata action existed, then we convert that schema into StructType and grab the generated columns from there
Signed-off-by: Ion Koutsouris <[email protected]>
Signed-off-by: Ion Koutsouris <[email protected]>
Signed-off-by: Ion Koutsouris <[email protected]>
Signed-off-by: Ion Koutsouris <[email protected]>
…te/create Signed-off-by: Ion Koutsouris <[email protected]>
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
feat/generated-columns
branch
from
c12d5e1 to
d541160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds generated columns.
Related Issue(s)