Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added workspace oauth source for UC #3152

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

hntd187
Copy link
Collaborator

@hntd187 hntd187 commented Jan 21, 2025

Description

The current providers don't cover getting tokens directly from the workspace. This PR adds that functionality.

Related Issue(s)

Documentation

https://docs.databricks.com/en/dev-tools/auth/oauth-m2m.html

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jan 21, 2025
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@hntd187 hntd187 changed the title feat: Added workspace oauth source for UC feat: added workspace oauth source for UC Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 71.91%. Comparing base (4193cb0) to head (d83b8df).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/catalog-unity/src/credential.rs 0.00% 32 Missing ⚠️
crates/catalog-unity/src/lib.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
- Coverage   71.98%   71.91%   -0.07%     
==========================================
  Files         137      137              
  Lines       44218    44263      +45     
  Branches    44218    44263      +45     
==========================================
+ Hits        31829    31832       +3     
- Misses      10352    10398      +46     
+ Partials     2037     2033       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hntd187 hntd187 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into delta-io:main with commit 3bff47b Jan 21, 2025
23 checks passed
@hntd187 hntd187 deleted the workspace-creds branch January 21, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants