Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update tokio to 1.40 and Android NDK to r27 #5885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Aug 15, 2024

Delta Chat for Android does not support Android 4 anymore,
so there is no reason to keep using unsupported NDK.

r27 is the latest LTS version of Android NDK.

Tested:

  • nix build .#deltachat-rpc-server-arm64-v8a-android
  • nix build .#deltachat-rpc-server-armv6l-linux

nix build .#deltachat-rpc-server-x86_64-android
and
nix build .#deltachat-rpc-server-x86-android
still fail, but we do not build it in CI.

@link2xt
Copy link
Collaborator Author

link2xt commented Sep 4, 2024

Corresponding Android PR: deltachat/deltachat-android#3229

@adbenitez
Copy link
Member

nix build .#deltachat-rpc-server-x86_64-android
and
nix build .#deltachat-rpc-server-x86-android
still fail, but we do not build it in CI.

what is the meaning/implications of this?

@adbenitez
Copy link
Member

this should not be merged until android PR is merged

@iequidoo

This comment was marked as resolved.

rustTarget = "armv7-linux-androideabi";
};
arm64-v8a = {
cc = "aarch64-linux-android21-clang";
rustTarget = "aarch64-linux-android";
};
x86 = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix build .#deltachat-rpc-server-x86_64-android
and
nix build .#deltachat-rpc-server-x86-android
still fail, but we do not build it in CI.

But don't these lines build exactly those configurations?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They fail if I try to build them. We don't build them in CI anyway so I did not try to resolve it.

Copy link
Collaborator

@iequidoo iequidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine, i don't use Android 4. Btw, tokio 1.40 is already released

@link2xt link2xt changed the title build: update tokio to 1.39 and Android NDK to r27 build: update tokio to 1.40 and Android NDK to r27 Sep 4, 2024
Delta Chat for Android does not support Android 4 anymore,
so there is no reason to keep using unsupported NDK.

r27 is the latest LTS version of Android NDK.

Tested:
- `nix build .#deltachat-rpc-server-arm64-v8a-android`
- `nix build .#deltachat-rpc-server-armv6l-linux`

`nix build .#deltachat-rpc-server-x86_64-android`
and
`nix build .#deltachat-rpc-server-x86-android`
still fail, but we do not build it in CI.
@link2xt
Copy link
Collaborator Author

link2xt commented Oct 23, 2024

With this NDK nix flake update android does not break the build like it happens with r24: #6094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants