-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update tokio to 1.40 and Android NDK to r27 #5885
base: main
Are you sure you want to change the base?
Conversation
130987e
to
eba71f8
Compare
eba71f8
to
a781645
Compare
a781645
to
ac7f933
Compare
Corresponding Android PR: deltachat/deltachat-android#3229 |
what is the meaning/implications of this? |
this should not be merged until android PR is merged |
This comment was marked as resolved.
This comment was marked as resolved.
ac7f933
to
7d19874
Compare
rustTarget = "armv7-linux-androideabi"; | ||
}; | ||
arm64-v8a = { | ||
cc = "aarch64-linux-android21-clang"; | ||
rustTarget = "aarch64-linux-android"; | ||
}; | ||
x86 = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix build .#deltachat-rpc-server-x86_64-android
and
nix build .#deltachat-rpc-server-x86-android
still fail, but we do not build it in CI.
But don't these lines build exactly those configurations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They fail if I try to build them. We don't build them in CI anyway so I did not try to resolve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine, i don't use Android 4. Btw, tokio 1.40 is already released
7d19874
to
5ca9ee1
Compare
Delta Chat for Android does not support Android 4 anymore, so there is no reason to keep using unsupported NDK. r27 is the latest LTS version of Android NDK. Tested: - `nix build .#deltachat-rpc-server-arm64-v8a-android` - `nix build .#deltachat-rpc-server-armv6l-linux` `nix build .#deltachat-rpc-server-x86_64-android` and `nix build .#deltachat-rpc-server-x86-android` still fail, but we do not build it in CI.
5ca9ee1
to
04edc4a
Compare
With this NDK |
Delta Chat for Android does not support Android 4 anymore,
so there is no reason to keep using unsupported NDK.
r27 is the latest LTS version of Android NDK.
Tested:
nix build .#deltachat-rpc-server-arm64-v8a-android
nix build .#deltachat-rpc-server-armv6l-linux
nix build .#deltachat-rpc-server-x86_64-android
and
nix build .#deltachat-rpc-server-x86-android
still fail, but we do not build it in CI.